From: Shawn O. Pearce <spearce@spearce.org>
Date: Wed, 14 Jan 2009 02:51:11 GMT
Subject: Re: [RESEND PATCH] fast-import: Cleanup mode setting.
Message-ID: <20090114025111.GY10179@spearce.org>
In-Reply-To: <94a0d4530901131846u2121e433ka8620fbb37c8470b@mail.gmail.com>

Felipe Contreras <felipe.contreras@gmail.com> wrote:
> 
> How about the attached patch?
> 
> "S_IFREG | mode" probably is only required for 0644 and 0755.
> 
> It doesn't make sense to do S_IFREG | S_IFLINK (0100000 | 0120000),
> since no bits are changed.

Looks fine to me.

-- 
Shawn.