From: Shawn O. Pearce Date: Wed, 14 Jan 2009 02:17:51 GMT Subject: Re: [RESEND PATCH] fast-import: Cleanup mode setting. Message-ID: <20090114021751.GW10179@spearce.org> In-Reply-To: Johannes Schindelin wrote: > On Wed, 14 Jan 2009, Felipe Contreras wrote: > > > "S_IFREG | mode" probably is only required for 0644 and 0755. > > Why should we want to have that patch? IOW what does it fix, and what > might it break? It cleans up the code to make it more readable. It makes no sense to be doing S_IFREG | S_IFLINK, which happens when the input is for a symlink. It doesn't break anything to do that | operation, but it also looks damn odd when reading the function. -- Shawn.