From: Adeodato Simó <dato@net.com.org.es>
Date: Mon, 12 Jan 2009 20:40:30 GMT
Subject: Re: [PATCH] Update bash completions to prevent unbound variable errors.
Message-ID: <20090112204030.GA23327@chistera.yi.org>
In-Reply-To: <200901121435.35547.bss@iguanasuicide.net>

* Boyd Stephen Smith Jr. [Mon, 12 Jan 2009 14:35:35 -0600]:

> >The attached patch replaces things like

> >         if [ -z "$1" ]

> >with

> >         if [ -z "${1-}" ]

> That looks ugly to me.  Any reason we shouldn't just "set +u" at the top of 
> the script?

`set +u` affects the shell globally, not just to the sourced file. If
you do that, you must be aware that you'll be preventing people from
running their shell in `set -u` mode. (Merely stating a fact here, not
giving any opinion.)

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
The problem I have with making an intelligent statement is that some
people then think that it's not an isolated occurrance.
                -- Simon Travaglia