From: Alexander Potashev <aspotashev@gmail.com>
Date: Sat, 10 Jan 2009 16:17:22 GMT
Subject: Re: [PATCH] format-patch: avoid generation of empty patches
Message-ID: <20090110161722.GA18859@myhost>
In-Reply-To: <d77df1110901100801s463bb43bt701a95df14f167d8@mail.gmail.com>

On 10:01 Sat 10 Jan     , Nathan W. Panike wrote:
> Hi:
> 
> On Sat, Jan 10, 2009 at 5:39 AM, Alexander Potashev
> <aspotashev@gmail.com> wrote:
> ...
> >
> > +               if (!commit->parents && !rev.show_root_diff)
> > +                       break;
> 
> Do you really want to stop getting commits?  It seems like the break
> statement here should be a continue.

AFAIU get_revision stops revision iteration when it appears to stay at
the root commit. So, if we will replace 'break' with 'continue', the
'while' loop will finish right after that 'continue'.

However, I might be wrong... please, correct me then.

> 
> Nathan Panike