From: martin f krafft <madduck@madduck.net>
Date: Thu, 08 Jan 2009 02:06:50 GMT
Subject: Re: [PATCH (topgit) 1/2] Implement setup_pager just like in git
Message-ID: <20090108020650.GC7345@lapse.rw.madduck.net>
In-Reply-To: <20090107220027.GA4946@roro3>

also sprach Kirill Smelkov <kirr@landau.phys.spbu.ru> [2009.01.08.1100 +1300]:
> > So I suppose you could use
> > 
> >   ${GIT_PAGER-${PAGER-less}}
> > 
> > or similar.
> 
> Good eyes, thanks!
> 
> I'll rework it.

I am not 100% on this, but I think nested {}'s are a bashism.

> On Wed, Jan 07, 2009 at 03:24:02PM +0100, Bert Wesarg wrote:
> > On Wed, Jan 7, 2009 at 12:27, Kirill Smelkov <kirr@landau.phys.spbu.ru> wrote:
> > > Martin, thanks for your review.
> > > +       # atexit(close(1); wait pager)
> > > +       trap "exec >&-; rm "$_pager_fifo"; rmdir "$_pager_fifo_dir"; wait" EXIT
> > I think you need to escape the double quotes.
> 
> Good eyes -- corrected and thanks!

You could also just use single quotes inside the double quotes.

-- 
martin | http://madduck.net/ | http://two.sentenc.es/
 
"he gave me his card
 he said, 'call me if they die'
 i shook his hand and said goodbye
 ran out to the street
 when a bowling ball came down the road
 and knocked me off my feet"
                                                        -- bob dylan
 
spamtraps: madduck.bogus@madduck.net