From: Robin Rosenberg Date: Sat, 03 Jan 2009 23:48:01 GMT Subject: Re: [JGIT PATCH 13/13] Add basic git daemon support to publish receive-pack Message-ID: <200901040048.01520.robin.rosenberg@dewire.com> In-Reply-To: <1229992043-1053-14-git-send-email-spearce@spearce.org> tisdag 23 december 2008 01:27:23 skrev Shawn O. Pearce: > + private static final Pattern SAFE_REPOSITORY_NAME = Pattern > + .compile("^[A-Za-z][A-Za-z0-9/_ -]+(\\.git)?$"); This restriction is too strict. Wouldn't any path not containing ".." be valid? In particular this did not work with my "EGIT.contrib" repo. I have a lot of repos with names llike "name.purpose". Just adding '.' to the character set isn't really enough. -- robin