From: Robin Rosenberg Date: Sat, 03 Jan 2009 22:12:52 GMT Subject: Re: [JGIT PATCH] Improve the sideband progress scaper to be more accurate Message-ID: <200901032312.53148.robin.rosenberg@dewire.com> In-Reply-To: <20081231190401.GI29071@spearce.org> onsdag 31 december 2008 20:04:01 skrev Shawn O. Pearce: > By matching only whole lines we should be able to improve the > progress scaper so we avoid ugly output like we had been seeing: > > EGIT.contrib/jgit clone git://repo.or.cz/libgit2.git LIBGIT2 > Initialized empty Git repository in /home/me/SW/LIBGIT2/.git > Counting objects: 547 > Compressing objects: 100% (192/192) > ts: 100% (192/192) > Compressing objects: 100% (192/192) > ng objects: 100% (192/192) > > Signed-off-by: Shawn O. Pearce > --- > Robin Rosenberg wrote: > > Would it be hard to get the progress look better? > > Maybe this does the trick. Its hard to reproduce so its hard to > come up with the condition that was giving us the problem before. > I suspect its because we were getting line fragments on the sideband > channel, but I'm not sure that was really the case. Nasty. I couldn't reproduce it myself. I'll hold onto this one for a while and see if I'll get the opportunity to test it live with this problem. -- robin