From: Jan Krüger <jk@jk.gs>
Date: Sat, 27 Dec 2008 18:08:19 GMT
Subject: Re: [PATCH] Add a commit.signoff configuration variable to always use --signoff.
Message-ID: <20081227190819.7257932a@neuron>
In-Reply-To: <1230296219-16408-1-git-send-email-dato@net.com.org.es>

Hi,

On Fri, 26 Dec 2008 13:56:59 +0100
"Adeodato Simó" <dato@net.com.org.es> wrote:

> > Has there even been talk of a commit.signoff configuration variable
> > to always add a S-o-b line? This could allow to enable it on a
> > per-project basis, which would be cool.
> 
> Well, it seemed easy enough to do, so I went ahead. Comments would be
> welcome.

I think it might be a good idea to allow overriding the config variable
in the other direction, i.e. a --no-signoff option to commit. Otherwise,
for example, rebase would have no way of suppressing the S-o-b lines in
rebased commits (and you might want to not automatically sign off
commits you rebase).

-Jan