From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Sat, 27 Dec 2008 13:30:05 GMT
Subject: Re: [JGIT PATCH 11/23] Rewrite WindowCache to use a hash table
Message-ID: <200812271430.06052.robin.rosenberg.lists@dewire.com>
In-Reply-To: <1230171079-17156-12-git-send-email-spearce@spearce.org>

torsdag 25 december 2008 03:11:07 skrev Shawn O. Pearce:
> diff --git a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> index f617845..f478f04 100644
> --- a/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> +++ b/org.spearce.jgit/src/org/spearce/jgit/lib/WindowCache.java
> @@ -41,11 +41,7 @@
>  import java.io.IOException;
>  import java.lang.ref.ReferenceQueue;
>  
> -/**
> - * The WindowCache manages reusable <code>Windows</code> and inflaters used by
> - * the other windowed file access classes.
> - */
> -public class WindowCache {
> +class WindowCache {

This breaks the Eclipse plugin which want to call WindowCache.reconfigure. Package level
class can also have javadocs. Even though we do not require it, I still thinks it's a good idea. Not
sure how useful that one was.

-- robin