From: Mark Burton Date: Thu, 18 Dec 2008 12:11:18 GMT Subject: Re: [PATCH 4/5] Make 'diff_populate_filespec()' use the new 'strbuf_readlink()' Message-ID: <20081218121118.3635c53c@crow> In-Reply-To: Howdy folks, When I compile this latest version of diff.c on a i686 dual-core Pentium box I see: diff.c: In function ‘diff_populate_filespec’: diff.c:1781: warning: passing argument 2 of ‘strbuf_detach’ from incompatible pointer type The same code compiles without warning on a x86_64 AMD box. Both machines are running stock Ubuntu 8.04. Does it need a cast on some architectures? Cheers, Mark