From: martin f krafft Date: Fri, 21 Nov 2008 12:06:09 GMT Subject: TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup) Message-ID: <20081121120609.GA10326@piper.oerlikon.madduck.net> In-Reply-To: <36ca99e90811210119s215513a8m7c12c8d55fd54d70@mail.gmail.com> I think you wanted to CC Petr, not Junio. It's also useful to CC Debian bugs if you know of them. :) also sprach Bert Wesarg [2008.11.21.1019 +0100]: > I really second this. Plus, I think its crucial to check that we are > not inside the .git directory before setting up topgit. Because git > rev-parse --git-dir only works in the top .git dir, not deeper (i.e. > inside .git/refs) and will always return ".". > > $(git rev-parse --is-inside-work-tree) || > die "Not in a git working directory" Thanks, noted. I am still working on this patch, since evaluating $argv/checking for --help at this early stage basically requires a rewrite of the CLI parsing, ideally using POSIX getopt or something similar, which takes much of the load away. Anyway, Patch for your proposal forthcoming. -- .''`. martin f. krafft : :' : proud Debian developer, author, administrator, and user `. `'` http://people.debian.org/~madduck - http://debiansystem.info `- Debian - when you have better things to do than fixing systems (a)bort, (r)etry, (p)retend this never happened