From: Petr Baudis Date: Thu, 20 Nov 2008 14:34:55 GMT Subject: Re: [TopGit PATCH] tg patch: disable pager and colors for git-diff Message-ID: <20081120143455.GH10544@machine.or.cz> In-Reply-To: <20081120135710.GA16303@diku.dk> On Thu, Nov 20, 2008 at 02:57:10PM +0100, Jonas Fonseca wrote: > When output is not redirected to a file, git brings up the pager for > only the diff, which can be confusing, so disable with --no-pager. > git-diff is a porcelain command and thus subject to color options. Use > --no-color, to avoid the patch being corrupted with terminal escape > characters when color.diff=always. > > Signed-off-by: Jonas Fonseca I still don't understand how did that color thing happen - shouldn't git diff avoid spewing out colors when the output is not a tty? And when it is, I want the colors myself, too. Good point with the --no-pager, but in that case, tg patch itself should by default invoke the pager, since it really is very desirable. -- Petr "Pasky" Baudis People who take cold baths never have rheumatism, but they have cold baths.