From: Jeff King <peff@peff.net>
Date: Wed, 12 Nov 2008 11:26:54 GMT
Subject: Re: Possible bug: "git log" ignores "--encoding=UTF-8" option if --pretty=format:%e%n%s%n is used
Message-ID: <20081112112654.GA20640@coredump.intra.peff.net>
In-Reply-To: <85647ef50811120311q7bc5451x7c084fd2a7864177@mail.gmail.com>

[re-adding list to the cc]

On Wed, Nov 12, 2008 at 02:11:46PM +0300, Constantine Plotnikov wrote:

> > I don't actually use any encodings except UTF-8, so maybe there is some
> > subtle reason not to do so that I don't understand, but I would have
> > expected all of the format placeholders to respect any --encoding
> > parameter.
> >
> Even if this is the bug, it would be better to leave the old behavior
> for backward compatibility reasons and introduce new placeholders.
> Currently tools have to decode messages according to the commit
> encoding, and changing behavior of options will break these tools
> that have implemented workaround for this problem.

Are there such tools? I assumed they would have complained about this as
a bug before writing their own encoding conversion tools. And this is,
AFAIK, the first bug report.

I don't mind playing it safe to avoid breaking other people's tools, but
I'm also not excited about adding a second, "respect encoding" version
of many placeholders (and it's not just %s and %b; I think you would
need author and committer names and emails, too).

-Peff