From: Miklos Vajna Date: Wed, 12 Nov 2008 02:01:58 GMT Subject: Re: [PATCH 3/4] git-remote rename: support branches->config migration Message-ID: <20081112020158.GK24201@genesis.frugalware.org> In-Reply-To: <7v63mtvkdx.fsf@gitster.siamese.dyndns.org> On Tue, Nov 11, 2008 at 04:49:14PM -0800, Junio C Hamano wrote: > There is something fishy going on between 2/4 and 3/4. 2/4 was advertised > to migrate remotes to config and had a call to migrate_file() for that > purpose. Here this one now allows to convert branches but there is no > change to the callsite of migrate_file(). > > Which would mean that 2/4 would convert branches/foo too. And this one is > only to remove the leftover branches/foo file. > > Or am I utterly confused? The trick is that 2/4 already added support for remotes/foo as it uses remote_get() and that detects remotes/foo as well, but that is completely unintentional. If you think it makes sense, just squash 3/4 to 2/4, I made it two separate patches because I think these are logically separate changes.