From: Francis Galiegue Date: Tue, 11 Nov 2008 11:30:27 GMT Subject: Re: [PATCH] git send-email: edit recipient addresses with the --compose flag Message-ID: <200811111230.28076.fg@one2team.com> In-Reply-To: <20081111014919.GI7408@ece.pdx.edu> Le Tuesday 11 November 2008 02:49:19 Tait, vous avez écrit : > > > > + if ($c_file =~ /^To:\s*+(.+)\s*\nCc:/ism) { > > > > > > Greedy operators are only supported with perl 5.10 or more... I think > > > it's a bad idea to use them... > > > > The problem here was that a space should follow the field, but it may > > not. The user may unwarily backup over it. "\s*" would match this > > case. > > > > But if there is a space, it is included in the "(.+)". > > Not in any version of Perl to which I have access. > And if you see a space in (.+), your regex engine is buggy anyway. -- Francis Galiegue ONE2TEAM Ingénieur système Mob : +33 (0) 6 83 87 78 75 Tel : +33 (0) 1 78 94 55 52 fge@one2team.com 40 avenue Raymond Poincaré 75116 Paris