From: Jeff King Date: Fri, 07 Nov 2008 22:09:55 GMT Subject: [PATCH 1/4] t5400: expect success for denying deletion Message-ID: <20081107220955.GA16058@coredump.intra.peff.net> In-Reply-To: <20081107220730.GA15942@coredump.intra.peff.net> Commit a240de11 introduced this test and the code to make it successful. Signed-off-by: Jeff King --- Reading over the mailing list postings which led to a240de11, I think it is simply a case that Jan didn't fully understand what expect_failure meant (it means "this is a test that is currently broken, but we hope to fix in the future", and not anything to do with the test_must_fail in the test itself). t/t5400-send-pack.sh | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/t5400-send-pack.sh b/t/t5400-send-pack.sh index 6fe2f87..da69f08 100755 --- a/t/t5400-send-pack.sh +++ b/t/t5400-send-pack.sh @@ -103,7 +103,7 @@ unset GIT_CONFIG GIT_CONFIG_LOCAL HOME=`pwd`/no-such-directory export HOME ;# this way we force the victim/.git/config to be used. -test_expect_failure \ +test_expect_success \ 'pushing a delete should be denied with denyDeletes' ' cd victim && git config receive.denyDeletes true && -- 1.6.0.3.866.gc189b