From: Shawn O. Pearce Date: Fri, 07 Nov 2008 19:25:06 GMT Subject: Re: [PATCH v2 3/3] pack-objects: honor '.keep' files Message-ID: <20081107192506.GB2932@spearce.org> In-Reply-To: <4913F859.8070500@op5.se> Andreas Ericsson wrote: > > Only -d should honor .keep, imo. .keep-files is nothing about "don't copy > objects from this file" and all about "never delete this file". > > The only muddying comes from you, who decided that .keep-files should > have impact on anything else than deleting the protected pack. Before that, > .keep files had a clear semantic, and repack's documentation was correct. > > How do you explain .keep-files now? "protects pack-files that will forever > be used"? Then why the hell is it called ".keep" instead of "eternal"? The _intent_ behind .keep files has always been to avoid copying the objects into a new pack during git-repack, because the objects are held in a pack that cannot be deleted. Sadly the implementation has never quite worked right, which is what led to this patch series I think. -- Shawn.