From: Jakub Narebski <jnareb@gmail.com>
Date: Wed, 05 Nov 2008 22:40:26 GMT
Subject: Re: [PATCH] gitweb: Fix mod_perl support.
Message-ID: <200811052340.27677.jnareb@gmail.com>
In-Reply-To: <200811060110.07965.angavrilov@gmail.com>

Alexander Gavrilov wrote:

> [...] it is necessary to declare all global
> variables as 'our' [...]
> 
> Signed-off-by: Alexander Gavrilov <angavrilov@gmail.com>

I have forgot about that when reviewing path_info patches. I'm sorry
about that. Good catch, and good explanation.

Acked-by: Jakub Narebski <jnareb@gmail.com>

> diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
> index c5254af..2174d4a 100755
> --- a/gitweb/gitweb.perl
> +++ b/gitweb/gitweb.perl
[...]

> -my $path_info = $ENV{"PATH_INFO"};
> +our $path_info = $ENV{"PATH_INFO"};
[...]

-- 
Jakub Narebski
Poland