From: Jeff King Date: Sun, 26 Oct 2008 04:52:00 GMT Subject: Re: [PATCH 4/7] textconv: don't convert for every operation Message-ID: <20081026045200.GA21178@coredump.intra.peff.net> In-Reply-To: <7vvdvg6xto.fsf@gitster.siamese.dyndns.org> On Sat, Oct 25, 2008 at 04:48:19PM -0700, Junio C Hamano wrote: > Another place that would benefit from ALLOW_TEXTCONV is the function > wt_status_print_verbose() in wt-status.c, where we generate preview diff > for "git commit -v". The output from that function is purely for human > consumption and does not have to be applicable. I agree, but it turned out not to be as straightforward as I had hoped, since status doesn't even parse diff.* config. See patches 7 and 8 in the series I just posted. -Peff