From: Jeff King <peff@peff.net>
Date: Fri, 24 Oct 2008 14:08:22 GMT
Subject: Re: [PATCH 3/5] refactor userdiff textconv code
Message-ID: <20081024140822.GA11612@coredump.intra.peff.net>
In-Reply-To: <4901D557.90106@viscovery.net>

On Fri, Oct 24, 2008 at 04:01:59PM +0200, Johannes Sixt wrote:

> Your reasoning makes sense, of course. (I thought that forgoing textconv
> in these cases would have a simpler implementation; but it can't be a lot
> simpler than yours.)

Yeah, I think preventing it entirely for this case would be much more
complex, since you would have to realize much sooner that a textconv was
going to happen.

> > +test_expect_failure 'textconv does not act on symlinks' '
> Can we trust your solution if you still have 'test_expect_failure' here? ;-)

Heh. It helps if I commit before format-patch. ;) Fortunately, this was
the only change I missed out on sending.

-Peff