From: Jeff King <peff@peff.net>
Date: Wed, 22 Oct 2008 08:20:17 GMT
Subject: Re: [PATCH v2] builtin-blame: Reencode commit messages according to git-log rules.
Message-ID: <20081022082016.GA18473@sigill.intra.peff.net>
In-Reply-To: <1224622557-6669-1-git-send-email-angavrilov@gmail.com>

On Wed, Oct 22, 2008 at 12:55:57AM +0400, Alexander Gavrilov wrote:

> +test_expect_success \
> +	'blame respects i18n.commitencoding' '
> +	git blame --incremental file | \
> +		grep "^\(author\|summary\) " > actual &&
> +	test_cmp actual expected

Even though it is POSIX, using backslashed grouping in 'grep' isn't
portable. It fails at least on Solaris 8, and you have to do:

  egrep "^(author|summary) "

instead. Of course, I can't get your test to pass even with that change,
but I think that is just a broken iconv on Solaris.

-Peff