From: Mike Hommey <mh@glandium.org>
Date: Wed, 22 Oct 2008 06:13:25 GMT
Subject: Re: [PATCH] git-svn: don't escape tilde ('~') for http(s) URLs
Message-ID: <20081022061325.GC8225@glandium.org>
In-Reply-To: <7vtzb5wr6v.fsf@gitster.siamese.dyndns.org>

On Tue, Oct 21, 2008 at 02:53:28PM -0700, Junio C Hamano wrote:
> Eric Wong <normalperson@yhbt.net> writes:
> 
> >> strace revealed that git-svn url-encodes ~ while svn does not do that.
> >>
> >> For svn we have:
> >> write(5, "<S:update-report send-all=\"true\" xmlns:S=\"svn:\">
> >> <S:src-path>https://sucs.org/~welshbyte/svn/backuptool/trunk</S:src-path>...
> >>
> >> While git-svn shows:
> >> write(7, "<S:update-report send-all=\"true\" xmlns:S=\"svn:\">
> >> <S:src-path>https://sucs.org/%7Ewelshbyte/svn/backuptool/trunk</S:src-path>...
> 
> This looks like an XML based request sequence to me (and svn is talking
> WebDAV here, right?);

XML based would be &126;, not %7E.
Anyways, aren't there ready-to-use url quoting functions in perl ?

Mike