From: Jeff King <peff@peff.net>
Date: Tue, 21 Oct 2008 00:39:35 GMT
Subject: Re: [PATCH] rebase-i-p: only list commits that require rewriting in todo
Message-ID: <20081021003935.GC32569@coredump.intra.peff.net>
In-Reply-To: <7vej2a3kl5.fsf@gitster.siamese.dyndns.org>

On Mon, Oct 20, 2008 at 04:36:38PM -0700, Junio C Hamano wrote:

> I do not remember the individual patches in the series, but I have to say
> that the script at the tip of the topic is, eh, less than ideal.
> 
> Here is a small untested patch to fix a few issues I spotted while reading
> it for two minutes.
> 
>  * Why filter output from "rev-list --left-right A...B" and look for the
>    ones that begin with ">"?  Wouldn't "rev-list A..B" give that?
> 
>  * The abbreviated SHA-1 are made with "rev-list --abbrev=7" into $TODO in
>    an earlier invocation, and it can be more than 7 letters to avoid
>    ambiguity.  Not just that "${r:0:7} is not even in POSIX", but use of
>    it here is actively wrong.
> 
>  * There is no point in catting a single file and piping it into grep.

All of those look like sane changes to me (I'll admit that before I
didn't even look at the script beyond the breakage on my test box).

-Peff