From: Jeff King <peff@peff.net>
Date: Mon, 20 Oct 2008 11:50:04 GMT
Subject: Re: [PATCH] rebase-i-p: only list commits that require rewriting in todo
Message-ID: <20081020115003.GA11309@coredump.intra.peff.net>
In-Reply-To: <0977b23f6c709d4aea76de7a88e9fe17272b31ea.1224055978.git.stephen@exigencecorp.com>

On Wed, Oct 15, 2008 at 02:44:38AM -0500, Stephen Haberman wrote:

> +					cat "$TODO" | grep -v "${rev:0:7}" > "${TODO}2" ; mv "${TODO}2" "$TODO"

Substring expansion (like ${rev:0:7}) is not portable. At least it
doesn't work on FreeBSD /bin/sh, and "it's not even in POSIX", I
believe.

-Peff