From: Shawn O. Pearce Date: Sat, 18 Oct 2008 01:50:10 GMT Subject: Re: [PATCH 1/3] for-each-ref: utilize core.warnambiguousrefs for strict refname:short format Message-ID: <20081018015010.GA14786@spearce.org> In-Reply-To: <7vod1ieptr.fsf@gitster.siamese.dyndns.org> Junio C Hamano wrote: > Shawn, was there any issue with this one? The patch changes the function > signature for no good reason (at least, it does not have anything to do > with the stated purpose of the change), but other than that, I think what > it attempts to do makes sense. No, aside from the signature issue I think its reasonable. -- Shawn.