From: Dmitry Potapov <dpotapov@gmail.com>
Date: Sun, 12 Oct 2008 13:39:34 GMT
Subject: Re: [PATCH] compat/cygwin.c - Use cygwin's stat if core.filemode == true
Message-ID: <20081012133934.GB21650@dpotapov.dyndns.org>
In-Reply-To: <1223765806-3332-1-git-send-email-mlevedahl@gmail.com>

On Sat, Oct 11, 2008 at 06:56:46PM -0400, Mark Levedahl wrote:
> diff --git a/compat/cygwin.c b/compat/cygwin.c
> index 423ff20..1fed265 100644
> --- a/compat/cygwin.c
> +++ b/compat/cygwin.c
> @@ -91,13 +91,20 @@ static int cygwin_stat(const char *path, struct stat *buf)
>   * functions should be used. The choice is determined by core.ignorecygwinfstricks.
>   * Reading this option is not always possible immediately as git_dir may be
>   * not be set yet. So until it is set, use cygwin lstat/stat functions.
> + * However, if core.filemode is true, we *must* use the Cygwin posix stat as
> + * the Windows stat fuctions do not determine posix filemode.
>   */
>  static int native_stat = 1;
> +static int core_filemode = 0;

Is it a reason to add a new variable instead of using trust_executable_bit?
And if so, why its default value is different? I know that this default does
not matter usually, because core.filemode is always stored in .git/config,
but still I don't like this discrapency.

Otherwise, I don't have any objection to this patch.

Dmitry