From: Petr Baudis Date: Sat, 11 Oct 2008 21:23:22 GMT Subject: Re: [PATCH] Git.pm: release hash and blob handles Message-ID: <20081011212322.GU10544@machine.or.cz> In-Reply-To: On Sun, Oct 12, 2008 at 03:29:28AM +0800, Ray Chuan wrote: > the methods > > * hash_and_insert_object > * cat_blob > > use bidirectional pipes to pull/push data from the various git > utilities, but they don't close them after this is complete. this > denies Git's subsequent attempts to use these resources, leading to > failure. > > a simple, reproducible test case can be seen at > http://rctay.spaces.live.com/blog/cns!59D3BFCD027B09E5!792.entry. Hmm, I don't understand why git-svn does not work for you, but this patch is not correct. The whole point of the infrastructure is to leave the pipes open so that subsequent calls _reuse_ these pipes. This leads to substantial speedup as you do not need to re-fork git all the time. -- Petr "Pasky" Baudis People who take cold baths never have rheumatism, but they have cold baths.