From: Jeff King <peff@peff.net>
Date: Sun, 05 Oct 2008 19:24:39 GMT
Subject: Re: git apply: git diff header lacks filename information for git diff --no-index patch
Message-ID: <20081005192439.GD6173@coredump.intra.peff.net>
In-Reply-To: <20081005191728.GA6173@coredump.intra.peff.net>

On Sun, Oct 05, 2008 at 03:17:28PM -0400, Jeff King wrote:

> Yes, I noticed that, as well. And obviously it looks bogus, but I
> thought I managed to get "git diff" to produce "a/dev/null" on some
> otherwise valid input, and so assumed that was something we were able to
> work around in applying the patch. But testing again today, I can't seem
> to get anything except this broken diff to say "a/dev/null". So probably
> I was just mistaken yesterday.

Ah, I found it. It was the fact that _text_ diffs using --no-index also
generate that bogosity. But of course they work fine, since we just
reject the "default" name from the "diff --git" line, but end up getting
the names from the "---" and "+++" lines.

-Peff