From: Petr Baudis <pasky@suse.cz>
Date: Thu, 02 Oct 2008 15:07:25 GMT
Subject: Re: [PATCH] gitweb: Add path_info tests to t/t9500-gitweb-standalone-no-errors.sh
Message-ID: <20081002150725.GP10544@machine.or.cz>
In-Reply-To: <20081002145010.19247.44420.stgit@localhost.localdomain>

On Thu, Oct 02, 2008 at 04:52:20PM +0200, Jakub Narebski wrote:
> Note that those tests only that there are no errors nor warnings
> from Perl; they do not check for example if gitweb doesn't use
> ARRAY(0x8e3cc20) instead of correct value in links, etc.
> 
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> This is the test thans to which I have dicovered errors in git_tree()
> fixed in previous email. Nevertheless those two patches are unrelated,
> so they are not numbered.
> 
> Those tests check _current_ situation, without $action, not
> $hash_parent parameters possible in path_info.

I didn't test the patch but it all looks sensible.

Acked-by: Petr Baudis <pasky@suse.cz>