From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Wed, 01 Oct 2008 17:48:09 GMT
Subject: Re: [EGIT PATCH 3/8] Dispose of allocated colors on finalize()
Message-ID: <200810011948.10041.robin.rosenberg.lists@dewire.com>
In-Reply-To: <20081001143718.GU21310@spearce.org>

onsdagen den 1 oktober 2008 16.37.18 skrev Shawn O. Pearce:
> Robin Rosenberg <robin.rosenberg@dewire.com> wrote:
[..]
> I think this is wrong.  Any color that we get from
[...]
> What was the rationale for disposing of these resources?  Did you
> identify that this is a resource leak somewhere?  Because I'd like
> to make sure I actually understand the SWT resource model better
> so I don't commit mistakes in the future.

I read the Color javadoc, but not the getSystemColor one. You are right, drop this patch
and the "dispose" hunk in the next patch (which was also a

-- robin