From: Shawn O. Pearce Date: Mon, 29 Sep 2008 16:35:23 GMT Subject: Re: [PATCH] parse-opt: migrate fmt-merge-msg. Message-ID: <20080929163523.GC18340@spearce.org> In-Reply-To: <1222595139-32087-2-git-send-email-madcoder@debian.org> Pierre Habouzit wrote: > Also fix an inefficient printf("%s", ...) where we can use write_in_full. > > Signed-off-by: Pierre Habouzit > --- > builtin-fmt-merge-msg.c | 50 +++++++++++++++++++++------------------------- > 1 files changed, 23 insertions(+), 27 deletions(-) Near as I can tell, this is based upon a merge commit in next. We can't do that. Patches need to be based on master, or worst-case on a topic head that is in next or pu (in which case the name of the topic, or its tip commit, is helpful in the note). -- Shawn.