From: Jeff King <peff@peff.net>
Date: Sun, 28 Sep 2008 16:12:50 GMT
Subject: Re: [PATCH] Implement a textconv filter for "git diff"
Message-ID: <20080928161250.GB30199@coredump.intra.peff.net>
In-Reply-To: <vpq8wtc1tf7.fsf@bauges.imag.fr>

On Sun, Sep 28, 2008 at 12:00:44PM +0200, Matthieu Moy wrote:

> Hmm, why not, and the textconv could be different (like comparing
> old:foo.doc with ./foo.odt).

Exactly.

> One has to be carefull not to call textconv for plumbing commands,
> since the generated patches are not applicable, and only for the eyes
> of the reader.

Right, but that is prevented by not loading the appropriate diff driver
config, I believe (and I didn't look closely at your implementation in
that respect, but I believe it is the same as mine, because both
porcelain and plumbing use the code in diff.c).

-Peff