From: Johan Herland Date: Wed, 24 Sep 2008 23:10:54 GMT Subject: [PATCH] for-each-ref: Fix --format=%(subject) for log message without newlines Message-ID: <200809250110.54229.johan@herland.net> 'git for-each-ref --format=%(subject)' currently returns an empty string if the log message does not contain a newline. This patch teaches 'git for-each-ref' to return the entire log message (instead of an empty string) if there is no newline in the log message. Signed-off-by: Johan Herland --- Normally, log messages in git have trailing newlines. However, it seems the "tag fixup commits" manufactured by cvs2svn/cvs2git (via git-fast-import) have single-line log message without trailing newlines. I have checked the other callers of copy_line(), and AFAICS they are not affected by this change, since that would violate the git object format. Have fun! :) ...Johan builtin-for-each-ref.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin-for-each-ref.c b/builtin-for-each-ref.c index 9b44092..e59bd80 100644 --- a/builtin-for-each-ref.c +++ b/builtin-for-each-ref.c @@ -321,8 +321,8 @@ static const char *find_wholine(const char *who, int wholen, const char *buf, un static const char *copy_line(const char *buf) { const char *eol = strchr(buf, '\n'); - if (!eol) - return ""; + if (!eol) // simulate strchrnul() + eol = buf + strlen(buf); return xmemdupz(buf, eol - buf); } -- 1.6.0.2.463.g7f0eb