From: pasky@suse.cz Date: Wed, 24 Sep 2008 23:57:36 GMT Subject: [PATCH 2/3] git-gui: Use git web--browse --stdin for safe URL passing Message-ID: <20080925000156.857197915@suse.cz> In-Reply-To: <20080924235734.697978308@suse.cz> The current code does not actually require this since the documentation URL should always pass through unmangled, but future users of start_browser() (as in the patch to follow) might require this. This patch has been sponsored by Novartis. Signed-off-by: Petr Baudis --- git-gui/git-gui.sh | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh index fc67eb8..4d2d600 100755 --- a/git-gui/git-gui.sh +++ b/git-gui/git-gui.sh @@ -2360,7 +2360,11 @@ if {[file isfile $doc_path]} { } proc start_browser {url} { - git "web--browse" $url + # We use --stdin here since passing URLs (especially with query + # strings) does insane things in MSysGit. + set fd [git_write "web--browse" "--stdin"] + puts $fd $url + close $fd } .mbar.help add command -label [mc "Online Documentation"] \ -- tg: (6e32399..) t/git-gui/web-browse-stdin (depends on: t/git-gui/web-browse t/web--browse/stdin)