From: Todd Zullinger <tmz@pobox.com>
Date: Sat, 20 Sep 2008 00:48:14 GMT
Subject: Re: [PATCH] Use dashless git commands in setgitperms.perl
Message-ID: <20080920004814.GM2939@inocybe.teonanacatl.org>
In-Reply-To: <gb1ej9$bg2$1@ger.gmane.org>

Jakub Narebski wrote:
> Todd Zullinger wrote:
> 
>>  # To save permissions/ownership data, place this script in your .git/hooks
>>  # directory and enable a `pre-commit` hook with the following lines:
>>  #      #!/bin/sh
>> -#     SUBDIRECTORY_OK=1 . git-sh-setup
>> +#     SUBDIRECTORY_OK=1 . git sh-setup
>>  #     $GIT_DIR/hooks/setgitperms.perl -r
>>  #
>>  # To restore permissions/ownership data, place this script in your .git/hooks
>>  # directory and enable a `post-merge` and `post-checkout` hook with the
>>  # following lines:
>>  #      #!/bin/sh
>> -#     SUBDIRECTORY_OK=1 . git-sh-setup
>> +#     SUBDIRECTORY_OK=1 . git sh-setup
>>  #     $GIT_DIR/hooks/setgitperms.perl -w
>>  #
> 
> The rest is probably O.K., but I don't think this change is good one.

I don't see git-sh-setup in /usr/bin with a default install of git
1.6, so without this change, wouldn't the comments be suggesting a
potentially broken hook configuration?

-- 
Todd        OpenPGP -> KeyID: 0xBEAF0CE3 | URL: www.pobox.com/~tmz/pgp
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Suppose I were a member of Congress, and suppose I were an idiot. But,
I repeat myself.
    -- Mark Twain