From: Dmitry Potapov <dpotapov@gmail.com>
Date: Thu, 18 Sep 2008 17:19:36 GMT
Subject: Re: [PATCH (GIT-GUI,GITK) 1/8] git-gui: Cleanup handling of the default encoding.
Message-ID: <20080918171936.GE21650@dpotapov.dyndns.org>
In-Reply-To: <bb6f213e0809181000l52c55e8ctdfa49a59002e60cf@mail.gmail.com>

On Thu, Sep 18, 2008 at 09:00:07PM +0400, Alexander Gavrilov wrote:
> 
> You are here missing the fact, that the actual current default for
> git-gui is not utf-8, but 'binary', essentially equivalent to
> ISO-8859-1.

In this case, I was just confused by the comment to the patch, which was
saying "Make diffs and blame default to the system (locale) encoding
instead of hard-coding UTF-8."

> UTF-8 was suggested by a patch that has been around in the
> 'pu' branch since January, and which I took as a base for my series.
> Gitk on the other hand uses the locale encoding.

I see... Then your patch makes perfect sense regardless of Windows
support, which was presented as the rationale for the patch.

Thanks,
Dmitry