From: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Date: Thu, 11 Sep 2008 22:47:58 GMT
Subject: Re: [JGIT PATCH 1/2] Issue 23: Resolve tag^0 as tag^{commit}
Message-ID: <200809120047.58484.robin.rosenberg.lists@dewire.com>
In-Reply-To: <20080911213927.GA20238@diku.dk>

torsdagen den 11 september 2008 23.39.27 skrev Jonas Fonseca:
> Repository.resolve("tag^0") failed with "not a commit". Fix it and add a
> test case for it.

It seems this case is not *that* special. It is tag^N == tag^{commit}^N
Same for tag~N == tag^{commit}~N-

My fault, i guess, but it would be nice of you fixed it while you are at it.

Second, the testcase in the second patch fails on my machine.

testDerefTaggedTagTree(org.spearce.jgit.lib.T0008_testparserev)
junit.framework.ComparisonFailure: expected:<[269e1253bad5c247c6bde37aa48ae1e03138206c]> but was:<[be83157b4ffe650d728ba4f98ad47b623b0d0c20]>
	at junit.framework.Assert.assertEquals(Assert.java:81)
	at junit.framework.Assert.assertEquals(Assert.java:87)
	at org.spearce.jgit.lib.T0008_testparserev.testDerefTaggedTagTree(T0008_testparserev.java:123)

-- robin