From: Jeff King <peff@peff.net>
Date: Tue, 09 Sep 2008 12:32:07 GMT
Subject: Re: [PATCH 1/4] is_directory(): a generic helper function
Message-ID: <20080909123207.GA25799@coredump.intra.peff.net>
In-Reply-To: <48C6508B.1080600@viscovery.net>

On Tue, Sep 09, 2008 at 12:31:39PM +0200, Johannes Sixt wrote:

> Junio C Hamano schrieb:
> > +/*
> > + * Do not use this for inspecting *tracked* content.  When path is a
> > + * symlink to a directory, we do not want to say it is a directory.
> 
> I though stat(2) checks the thing that a symlink points to. Then either
> this comment is not correct or you want to use lstat(2), no?

I assume he meant "do not use this for tracked content, because in that
case...". But I had to read it twice to make sense.

> > + * Worth yet, leading components in path could contain symbolic links.

And this didn't help. I assume it should be "worse yet" and Junio
developed some sort of typing lisp?

-Peff