From: Abhijit Menon-Sen Date: Mon, 08 Sep 2008 10:16:31 GMT Subject: Re: [PATCH] t/t91XX-svn: start removing use of "git-" from these tests Message-ID: <20080908101631.GA6948@toroid.org> In-Reply-To: <20080908190205.6117@nanako3.lavabit.com> At 2008-09-08 19:02:05 +0900, nanako3@lavabit.com wrote: > > This first step replaces literal strings "remotes/git-svn" and > "git-svn-id" by introducing $remotes_git_svn and $git_svn_id > constants defined as shell variables. I'm sorry, but... why? I don't see the point at all. These are not even commands; and, as someone who was just reading the svn tests, the change certainly doesn't make them *easier* to follow. -- ams