From: Jeff King Date: Fri, 05 Sep 2008 19:41:58 GMT Subject: Re: [PATCH] Add --dirstat-by-file diff option Message-ID: <20080905194158.GA31826@coredump.intra.peff.net> In-Reply-To: <20080905192735.GA12853@zakalwe.fi> On Fri, Sep 05, 2008 at 10:27:35PM +0300, Heikki Orsila wrote: > --dirstat-by-file is the same as --dirstat, but it counts > "impacted files" instead of "impacted lines" (lines that > are added or removed). > > The patch also cleans --cumulative option handling. > DIFF_OPT_CUMULATIVE_DIRSTAT is used instead of > DIFF_FORMAT_CUMULATIVE. I was going to suggest that this actually be split into two patches for readability, but lo and behold, Junio has already committed a fix for --cumulative to next. So you probably should rebase your other changes (which look reasonable to me) on top of that. -Peff