From: Heikki Orsila Date: Wed, 03 Sep 2008 00:39:17 GMT Subject: Re: Re* [PATCH] Add --filedirstat diff option Message-ID: <20080903003916.GD1252@jolt.modeemi.cs.tut.fi> In-Reply-To: <7vbpz6dqd0.fsf_-_@gitster.siamese.dyndns.org> On Tue, Sep 02, 2008 at 05:28:59PM -0700, Junio C Hamano wrote: > But you are right to point out that --cumulative is an option that affects > how --dirstat operates. And I think the option parsing of that code is > buggy. It should imply --dirstat, shouldn't it? Yes. > Here is a sample patch to fix --cumulative (but of course it is untested); > I think your --filemode (or whatever its final name is) should hook into > the same place as this patch touches, as far as command line parsing is > concerned. I'll prepare something later today.. -- Heikki Orsila heikki.orsila@iki.fi http://www.iki.fi/shd