From: Shawn O. Pearce <spearce@spearce.org>
Date: Mon, 01 Sep 2008 19:40:04 GMT
Subject: Re: [PATCH] git gui: use apply --unidiff-zero when staging hunks without context
Message-ID: <20080901194004.GH7482@spearce.org>
In-Reply-To: <20080830210007.GA15004@localhost>

Clemens Buchacher <drizzd@aon.at> wrote:
> On Sat, Aug 30, 2008 at 01:52:23PM -0700, Junio C Hamano wrote:
> > Well, showing is Ok as long as you do not try pick and apply.  Or did I
> > miss something?
> 
> If I understand correctly git gui bases its patches on what it shows in the
> diff window - which makes sense, because otherwise it would be a PITA to
> find out which hunk the user actually wanted.
> 
> We could allow diffs without context and disable staging in that case, but I
> suspect this would only confuse the user.

I agree.  Lets just disallow zero-context diffs.  Its far easier
for the user to understand the diff limit is 1.

-- 
Shawn.