From: Christian Couder <chriscool@tuxfamily.org>
Date: Sun, 31 Aug 2008 01:53:47 GMT
Subject: Re: [PATCH] Start conforming code to "git subcmd" style
Message-ID: <200808310353.47699.chriscool@tuxfamily.org>
In-Reply-To: <7vwshyfctu.fsf@gitster.siamese.dyndns.org>

Le samedi 30 août 2008, Junio C Hamano a écrit :
>
> The command name at the beginning of die message does not have this
> issue. E.g. the colon in:
>
> 	die("git foo: I hate you");
>
> is sufficient to make it clear that these two words form a single noun;
> i.e. "I'm 'git foo' program, and I am telling you that I hate you".
>
> But it might be just me, so before asking you to reroll another round,
> I'd like to hear opinions from the list.
>
>  (1) No, JC is worrying too much about readability; Heikki's patch is
> good;
>
>  (2) JC's right -- "instead of calling 'git rev-list'" is much better;

I agree with (2).

Regards,
Christian.

>  (3) Something else?