From: Jeff King <peff@peff.net>
Date: Thu, 28 Aug 2008 21:33:22 GMT
Subject: Re: [PATCH v2] allow user aliases for the --author parameter
Message-ID: <20080828213322.GB27867@coredump.intra.peff.net>
In-Reply-To: <48B66783.4050305@fastmail.fm>

On Thu, Aug 28, 2008 at 10:53:23AM +0200, Michael J Gruber wrote:

> > Anyway, I think it is already not a good idea because of the semantics,
> > let alone the performance.
> 
> By "it" you are referring to
> - checking for uniqueness or
> - the whole approach combing through commits?

Sorry, I meant "checking for uniqueness." I think combing through is a
fine idea, but checking for uniqueness will come up with false
positives.

> I'd be happy with the patch as is (+"-i" maybe) now that I understand
> the template... (I tried --author=key with a key expanding to the
> (default) committer, in which case the commit template does not show
> author nor committer. Duh.)

You could pull the first from either (I think you will have to look at
the revision.c code at a little bit lower level -- look at how --author
adds grep fields). In a patch-by-mail repository like git.git, Junio is
almost always the committer. But other projects will have different
workflows.

> > PS Your message also didn't go to git@vger, so I think you are having
> > the same problem with Michael's message that I am.
> 
> OK: I send this To: Jeff, Cc: Junio, Nntp:
> gmane.comp.version-control.git (using Thunderbird 2). (This is the
> result of hitting "reply all" and deleting git@vger, because it's
> duplicated by gmane...git.)

Ah, OK. So your message ends up in my mailbox without a mention of
git@vger at all. It of course has a "newsgroups" header, but that is not
helpful for people who do not use gmane at all. And given that this is
primarily a mailing list which has a newsgroup interface, and not vice
versa, I think it makes sense to give priority to the mail interface.

Is there a reason to post through gmane at all? Why not just leave the
git@vger cc, and kill the nntp post?

-Peff