From: Stephen R. van den Berg Date: Wed, 27 Aug 2008 17:22:06 GMT Subject: Re: [PATCH v4] make git-shell paranoid about closed stdin/stdout/stderr Message-ID: <20080827172206.GA27450@cuci.nl> In-Reply-To: Paolo Bonzini wrote: >Fixing this in git was considered to be overkill, so this patch works >around it only for git-shell. The fix is simply to open all the "low" >descriptors to /dev/null in main. Since git-shell is not setuid, this strictly is not necessary, however, I concur that git-shell is potentially started in a partially broken environment which is not always easily fixable by the user. And since git-shell needs to sanitise the filedescriptors anyway before launching other programs, it might as well cleanup at startup if needed. Acked-by: Stephen R. van den Berg -- Sincerely, Stephen R. van den Berg. "First, God created idiots. That was just for practice. Then he created school boards." -- Mark Twain