From: Jakub Narebski <jnareb@gmail.com>
Date: Mon, 25 Aug 2008 02:44:22 GMT
Subject: Re: [PATCH v5] gitweb: ref markers link to named shortlogs
Message-ID: <200808250444.23305.jnareb@gmail.com>
In-Reply-To: <20080825020502.GQ23800@genesis.frugalware.org>

Miklos Vajna wrote:
> On Mon, Aug 25, 2008 at 01:53:30AM +0200, Jakub Narebski <jnareb@gmail.com> wrote:
> >
> > We strip leading "refs/" in git_get_references(), so $ref does not
> > contain it. I'm not sure of one has to use refs/heads/aaa and refs/tags/aaa
> > to distinguish between tag and head with the same name, or heads/aaa and
> > tags/aaa is enough.
> 
> You can have both heads/master and refs/heads/master, then heads/master
> is ambiguous.
> 
> Given that git fsck will not barf on such a configuration, I think
> gitweb should handle such a case as well.

What I wanted to say was that I am not sure if current

+                     $markers .= " <span class=\"$class\" title=\"$ref\">" .
+                             $cgi->a({-href => href(action=>( $indirect ? "tag" : "shortlog"),
+                                                    hash=>$ref)}, $name) .
+                             "</span>";

is enough, or should gitweb use

+                     $markers .= " <span class=\"$class\" title=\"$ref\">" .
+                             $cgi->a({-href => href(action=>( $indirect ? "tag" : "shortlog"),
+                                                    hash=>"refs/$ref")}, $name) .
+                             "</span>";

or equivalent (not stripping "refs/" in git_get_references).

P.S. We are interested _only_ in refs shown by git-show-ref.
-- 
Jakub Narebski
Poland