From: Robin Rosenberg Date: Fri, 22 Aug 2008 20:45:08 GMT Subject: Re: [JGIT PATCH 1/4] Simplify and micro-optimize WorkingTreeIterator.ENTRY_CMP Message-ID: <200808222245.08814.robin.rosenberg.lists@dewire.com> In-Reply-To: <1219352258-15431-1-git-send-email-spearce@spearce.org> torsdagen den 21 augusti 2008 22.57.35 skrev Shawn O. Pearce: > We already did this simplification work to AbstractTreeIterator's > pathCompare method, and this is based upon that same structure. I noticed we have very bad code coverage in unit tests in this area of the code. Maybe we should increase the coverage before optimizing. I'll accept the patches anyway and pray they are ok. -- robin