From: Johan Herland <johan@herland.net>
Date: Fri, 22 Aug 2008 13:27:21 GMT
Subject: Re: [BUG?] 'git verify-pack -v' on multiple packs fails for all but the first pack
Message-ID: <200808221527.21971.johan@herland.net>
In-Reply-To: <200808221439.31219.johan@herland.net>

On Friday 22 August 2008, Johan Herland wrote:
> (I don't have time to look into this right now, but will do so later
> if nobody comes up with a solution in the meantime...)
>
> When running 'git verify-pack -v' on multiple packs (.idx files), it
> fails for all packs, except the first, with exit code 128, and the
> following single line:
>
> 	fatal: internal error: pack revindex fubar
>
> This does not happen when given only a single pack, or when given
> multiple packs, but without '-v' option.
>
> To reproduce, simply do:
>
> 	git verify-pack -v .git/objects/pack/*.idx
>
> in any repo with more than one pack file.
>
> This happens with a fairly current 'next' (1.6.0.96.g2fad1). AFAICS,
> it also happens in v1.6.0.

Bisection point to this commit:

commit 1f5c74f6cf918d317c73b328dcd4cf6f55c44d8a
Author: Nicolas Pitre <nico@cam.org>
Date:   Mon Jun 23 21:22:14 2008 -0400

    call init_pack_revindex() lazily

    This makes life much easier for next patch, as well as being more efficient
    when the revindex is actually not used.

    Signed-off-by: Nicolas Pitre <nico@cam.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>


-- 
Johan Herland, <johan@herland.net>
www.herland.net