From: Björn Steinbrink Date: Wed, 20 Aug 2008 20:02:01 GMT Subject: Re: diff --check is stupid about blank lines Message-ID: <20080820200201.GA3210@atjola.homenet> In-Reply-To: <7vskszr0it.fsf@gitster.siamese.dyndns.org> On 2008.08.20 11:42:34 -0700, Junio C Hamano wrote: > Junio C Hamano writes: > > Instead, data.trailing_blanks_start is supposed to be reset to 0 every > > time we see non-blank newline, a copied context line, or new hunk. > > > > So if this triggers with -U0 I'd understand, but otherwise I do not see > > how. > > Ahhh, what idiot wrote the logic for checking trailing blank lines in > checkdiff_consume(). > > It does not ask for any context lines. Sheesh. > > This should fix it. Thanks, works for me :-) Björn