From: Shawn O. Pearce <spearce@spearce.org>
Date: Tue, 19 Aug 2008 19:59:28 GMT
Subject: Re: [PATCH] add a 'pre-push' hook
Message-ID: <20080819195928.GB24212@spearce.org>
In-Reply-To: <20080819190832.GC17943@coredump.intra.peff.net>

Jeff King <peff@peff.net> wrote:
> I think the common wisdom has been that such tests should be done on the
> _receiving_ end, since that makes a more trustworthy enforcement point.
> E.g., I know that crap can't get into my central repo because a hook
> checks everything coming in. But if a developer has turned off his
> pre-push hook (or accidentally failed to enable it), he can still send
> crap.
> 
> One other argument I have seen is that, to prevent the proliferation of
> hooks, the rule is not to add a hook that could just as easily be done
> as a sequence of commands. IOW, what's wrong with
> 
>   run_my_automated_tests && git push

Yup, I agree completely.

Why not just setup an alias:

	git config alias.send '! run_my_tests && git push "$@"'

and retrain your fingers to use "git send ..."?
 
-- 
Shawn.